Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax yang.settings JSON Schema for extensions #242

Closed
esmasth opened this issue Apr 23, 2024 · 1 comment
Closed

Relax yang.settings JSON Schema for extensions #242

esmasth opened this issue Apr 23, 2024 · 1 comment

Comments

@esmasth
Copy link
Contributor

esmasth commented Apr 23, 2024

Extensions can add diagnostic properties, but current JSON Schema does not
allow additionalProperties to diagnostic.
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 23, 2024
@esmasth
Allow extension yang.settings JSON Schema extensibility
31d587c 
This addresses TypeFox#242

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
@esmasth esmasth mentioned this issue Apr 23, 2024
Merged
dhuebner pushed a commit that referenced this issue Jun 18, 2024
@esmasth
Allow extension yang.settings JSON Schema extensibility (#243)
3697fbd 
* Allow extension yang.settings JSON Schema extensibility

This addresses #242

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>

* Document multiple extension classpaths

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>

---------

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
@esmasth
Copy link
Contributor Author

esmasth commented Jun 18, 2024

#243 was merged, hence this can be considered done

@esmasth esmasth closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@esmasth