-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to latest LSP #89
Conversation
c7abcfb
to
1a8247c
Compare
Please review.
As the next step i am going to publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't scrutinize the changes super thoroughly as there's quite a bit but I gave it a test run with my own language server and it seemed okay. Great work, Anton!
@rcjsuen many thanks for trying it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I am working on new version of monaco-languageclient to catch it up with vscode-languageclient: TypeFox/monaco-languageclient#89 And for it i have to customize how a connection is created and which features are enabled by default. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
I am working on a new version of `monaco-languageclient` to catch it up with `vscode-languageclient`: TypeFox/monaco-languageclient#89 And for it, I have to customize how a connection is created and which features are enabled by default. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
a9064da
to
f691aec
Compare
We've decided to keep vscode-base-languageclient as a vscode-languageclient transpiled to es5. As soon as microsoft/vscode-languageserver-node#382 is resolved, we can abandon vscode-base-languageclient completely. |
9060e91
to
f24cb59
Compare
vscode compatibility layer is introduced in order to make use of vscode-languageclient directly instead of vscode-base-languageclient Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
f24cb59
to
8dbf33c
Compare
vscode compatiblity layer is introduced to make use of vscode-languageclient directly instead of vscode-base-languageclient