Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[TT-8935] Fix snapshot panic #628

Merged
merged 3 commits into from
May 19, 2023
Merged

[TT-8935] Fix snapshot panic #628

merged 3 commits into from
May 19, 2023

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented May 18, 2023

Description

Upgraded github.com/json-iterator/go version to v1.1.12 since support of go 1.18 was fixed in that version.

Related Issue

TT-8935

Motivation and Context

Fix snapshot tool panic

Test Coverage For This Change

Verified APIDefinition, Policy is exported successfully by snapshot tool.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@komalsukhani komalsukhani changed the title Upgrade github.com/json-iterator/go version to v1.1.12 [TT-8935] Fix snapshot panic May 18, 2023
@komalsukhani komalsukhani marked this pull request as ready for review May 18, 2023 07:26
@komalsukhani komalsukhani requested a review from a team as a code owner May 18, 2023 07:26
@komalsukhani komalsukhani requested review from buraksekili and removed request for a team May 18, 2023 07:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@singhpr singhpr merged commit c889b7e into master May 19, 2023
@singhpr singhpr deleted the fix/TT-8935/fix-panic branch May 19, 2023 06:00
buger pushed a commit that referenced this pull request May 22, 2024
* Upgrade `github.com/json-iterator/go` version to v1.1.12

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants