Added possibility to set base identity provider for multiple chained …

[bogumillaska]

Adding the possibility to set base_identity_provider through tyk-operator.

Description

Currently you are able to set mutliple auth mechanism - however base_identity_provider remains empty which makes the dashboard confused about the true authentication type selected. That has implications for key creatation and update.
Until this PR - if you :

1. create an apidefinition with use_basic_auth and use_mutual_tls_auth enabled
2. process that through tyk-operator
3. create policy with previously created API
4. create key in the dashboard
5. observe that the key only recognizes basic authentication and it is not enforcing mTLS certificate

Related Issue

NA

Motivation and Context

We are using multiple authentication on our project and we want our API to be fully compliant with standard to rule out unpredictable behavior

Test Coverage For This Change

Added unit test TestApiDefinitionBaseIdentityProviderWithMultipleAuthTypes in apidefinition_test.go following a similar structure to the mtls configuration.
Added config/samples/multiple-auth/httpbin_basic_authentication_and_mTLS.yaml
Executed manual tests on kind cluster using ce mode

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
• Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
• Make sure you are updating CHANGELOG.md based on your changes.
• My change requires a change to the documentation.
  • If you've changed APIs, describe what needs to be updated in the documentation.
• I have updated the documentation accordingly.
• If you've changed API models, please update CRDs.
  • make manifests
  • make helm
• I have added tests to cover my changes.
• All new and existing tests passed.
• Check your code additions will not fail linting checks:
  • gofmt -s -w .
  • go vet ./...
  • golangci-lint run

[komalsukhani]

@bogumillaska Thank you for the contribution. I have reviewed the PR it looks great just need one change.

[bogumillaska]

Ah! @komalsukhani - thank you! Nice catch.
I also fixed a line from my previous contribution. However, I did find similar situations in other tests and I did not attempt to make a change of them all in this contribution.

[komalsukhani]

However, I did find similar situations in other tests and I did not attempt to make a change of them all in this contribution.
Ohh. I will raise an internal ticket to fix them.

I have approved the PR. It will be merged once QA tests it and will be available in patch release of Operator.
Thank you again.

[komalsukhani]

I was trying this PR and demoing to my team. Got some suggestions. Can you please resolve them?

[bogumillaska]

@komalsukhani I applied all the changes.

[komalsukhani]

@bogumillaska Looks perfect!! I will hand it over to QA to test.