Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Move all operations regarding API configuration to a function #557

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Move all operations regarding API configuration to a function #557

merged 5 commits into from
Jan 12, 2023

Conversation

buraksekili
Copy link
Collaborator

@buraksekili buraksekili commented Jan 9, 2023 •
edited
Loading

Description

Previously, integration tests replicated the same logic to create context.Context to make API calls to Tyk. So, this PR replaces all replicated logic with already defined function.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@buraksekili buraksekili marked this pull request as ready for review January 11, 2023 13:52
@buraksekili buraksekili requested a review from a team as a code owner January 11, 2023 13:52
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team January 11, 2023 13:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@komalsukhani komalsukhani merged commit 26ccfca into master Jan 12, 2023
@komalsukhani komalsukhani deleted the refactor/unify-ctx-constructors branch January 12, 2023 07:48
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili
Move all operations regarding API configuration to a function (#557)
3821611 
* Replace all operations regarding context preparation for API calls with a helper function

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* Add wait conditions to delete operation on k8s

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@komalsukhani komalsukhani komalsukhani approved these changes

@andrei-tyk andrei-tyk Awaiting requested review from andrei-tyk andrei-tyk was automatically assigned from TykTechnologies/operator-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buraksekili @komalsukhani