This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Added security policy settings for GraphQL #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated graphql-go-tools package - so, use Tyk's fork. Updated go.mod dependencies. Added required DeepCopy functions for external graphql.Type field. Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
…nologies/tyk-operator into feature/TT-5209/graphql-policies
Remove leftover description on sample manifest and update the sample description accordingly.
…nologies/tyk-operator into feature/TT-5209/graphql-policies
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
komalsukhani
approved these changes
Jan 9, 2023
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Added security policy settings for GraphQL. Updated graphql-go-tools package - so, use Tyk's fork. Updated go.mod dependencies. Added required DeepCopy functions for external graphql.Type field. Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Add e2e tests Signed-off-by: Burak Sekili <buraksekili@gmail.com> * remove extra lines Signed-off-by: Burak Sekili <buraksekili@gmail.com> * updated changelog Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Move GW specific fields to out of comparison Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Remove redundant docs links from CRD manifests Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Add example manifest for Restricted Types Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update sample manifest; so, it includes GraphQL API with authorization Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update restricted-types-policy.yaml Remove leftover description on sample manifest and update the sample description accordingly. * Run policy tests in CE too Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update Tyk version to v4.3 for SecurityPolicy API Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Skip tests in versions below v4.3 Signed-off-by: Burak Sekili <buraksekili@gmail.com> Signed-off-by: Burak Sekili <buraksekili@gmail.com> Co-authored-by: Pranshu <104971506+singhpr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to policy fields that apply to GraphQL.
Related Issue
https://tyktech.atlassian.net/browse/TT-5209
Motivation and Context
Previously, there was no way to set GraphQL-specific policies through CR. This PR adds corresponding fields to SecurityPolicy CR.
Added support of
allowed_types,restricted_types,disable_introspectionandfield_access_rightsfields of SecurityPolicy.Test Coverage For This Change
Added e2e tests to ensure that corresponding fields are appropriately set on Tyk and K8s.
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run