Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC][TT-11212]kin-openapi-upgrade #420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffy-mathew
Copy link

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@buraksezer
Copy link

Hey @jeffy-mathew, thank you for opening this PR. I tried to upgrade the OpenAPI parser on my local. It seems that we can upgrade it to the latest with little effort but one of the integration tests is broken. If you can give more information about how it is urgent for your team, we can make some arrangements on our side.

@jeffy-mathew jeffy-mathew force-pushed the poc/TT-11212/kin-openapi-upgrade branch from 32c2933 to f0b412f Compare April 17, 2024 12:26
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeffy-mathew
Copy link
Author

jeffy-mathew commented Apr 17, 2024

@buraksezer thanks for your interest and sorry for the late reply. We're looking into identifying the impact of upgrading the openapi library(had to deprioritize it after our last cooldown). With this PR and related PRs in gateway and dashboard we found it's a relatively easy upgrade. Right now I'm analysing what are the potential impacts of upgrading from different versions. Once that's assessed and if there aren't any blockers, we will be able to fast track this.
In the mean time, could you help us with the integration tests you've mentioned?

However I can see that kin-openapi isn't a dependancy in this repo anymore.
So I assume it's safe to close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants