Skip to content

Commit

Permalink
Enable Clang 18 builds on CI (#349)
Browse files Browse the repository at this point in the history
* Enable Clang 18 builds on CI

* Debug failure on CI

* Use FMT in Clang 18, no std::format support till Clang 19

* Find FMT when required

* Build under C++23
  • Loading branch information
Twon authored Feb 9, 2025
1 parent ca917dd commit 7a3725b
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
28 changes: 14 additions & 14 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,20 +105,20 @@ jobs:
},
lib: "libc++",
}
# - {
# name: "Ubuntu Clang-18 + libc++",
# os: ubuntu-latest,
# compiler:
# {
# type: CLANG,
# version: 18,
# conan: "clang",
# cc: "clang-18",
# cxx: "clang++-18",
# std: 20
# },
# lib: "libc++",
# }
- {
name: "Ubuntu Clang-18 + libc++",
os: ubuntu-latest,
compiler:
{
type: CLANG,
version: 18,
conan: "clang",
cc: "clang-18",
cxx: "clang++-18",
std: 23
},
lib: "libc++",
}
# - {
# name: "Ubuntu Clang-19 + libc++",
# os: ubuntu-latest,
Expand Down
2 changes: 1 addition & 1 deletion conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def useFMT(self):
compiler = self.settings.compiler
version = Version(self.settings.compiler.version)
std_support = (compiler == "msvc" and version >= 193) or (compiler == "gcc" and version >= Version("14")) or \
(compiler == "clang" and version >= Version("18"))
(compiler == "clang" and version >= Version("19"))
return not std_support

def config_options(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ morpheus_conformance_check(
RESULT FORMAT_SUPPORTED
MSVC_VERSION "19.37"
GNU_VERSION "14"
CLANG_VERSION "18"
CLANG_VERSION "19"
)

if (NOT ${DATE_SUPPORTED})
Expand Down

0 comments on commit 7a3725b

Please sign in to comment.