Added bbox parameter to @turf/interpolate #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsaucepan
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Hi @lemonig. Thanks for this PR. Have a couple of minor changes to request and a question about checkBbox if you could please take a look.
smallsaucepan
approved these changes
Dec 16, 2024
|
Thanks heaps for that following through on this @lemonig 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template. Use a meaningful title for the pull request. Include the name of the package modified.
I created three new test files with bbox, and the generated results were in line with expectations after my testing. But I don't know if every test file needs to create a new file with bbox in it
Resolves #1031
Resolves #2444