Used actor URI in site.changed update activity
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs [AP-357](https://linear.app/tryghost/issue/AP-357/publickey-mismatch-on-update-causing-re-follows) When publishing an update as a result of processing a `site.changed` webhook it was noticed that Mastodon was triggering a re-follow of the actor. This down to the `publicKey` property contained in the update object being different to the one Mastodon has stored for the actor. In the case here, `publicKey` is actually missing from the actor due to a serialisation issue within Fedify, so have opted to use the `id` of the actor instead of the full actor object and let Mastodon dereference to get the updated actor object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs AP-357
When publishing an update as a result of processing a
site.changedwebhook it was noticed that Mastodon was triggering a re-follow of the actor. This down to thepublicKeyproperty contained in the update object being different to the one Mastodon has stored for the actor. In the case here,publicKeyis actually missing from the actor due to a serialisation issue within Fedify, so have opted to use theidof the actor instead of the full actor object and let Mastodon dereference to get the updated actor object