Used exec to run tests in existing container #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea here is to simplify and streamline the dev stack. So rather than a separate docker-compose file for testing, and spinning up new containers we can run the tests in the existing activitypub container we use, which also has the local src files mounted. `yarn dev` will start the stack as usual, but now it does it as a daemon, which means it runs in the background. We also pass the --no-recreate flag which ensures that running it multiple times doesn't destroy the container and is essentially idempotent. `yarn logs` will tail the activitypub logs for the container `yarn test` uses the `exec` docker compose command to run the tests, and also calls `yarn dev` first - which makes sure the stack is running if it wasn't already.
mike182uk
reviewed
Jul 30, 2024
mike182uk
reviewed
Jul 30, 2024
mike182uk
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to simplify and streamline the dev stack. So rather than a separate docker-compose file for testing, and spinning up new containers we can run the tests in the existing activitypub container we use, which also has the local src files mounted.
yarn devwill start the stack as usual, but now it does it as a daemon, which means it runs in the background. We also pass the --no-recreate flag which ensures that running it multiple times doesn't destroy the container and is essentially idempotent.yarn logswill tail the activitypub logs for the containeryarn testuses theexecdocker compose command to run the tests, and also callsyarn devfirst - which makes sure the stack is running if it wasn't already.