refactor and improve

- update tribes-list.client.controller - fix propTypes warnings - cleanup
Trustroots · Dec 14, 2019 · 23b6138 · 23b6138
1 parent a2ce198
commit 23b6138
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/modules/tribes/client/components/Tribe.js b/modules/tribes/client/components/Tribe.js
@@ -12,9 +12,6 @@ const Container = styled.div`
   position: relative;
 `;
 
-/**
- * @TODO maybe rename to Tribe
- */
 export default function Tribe({ tribe, user, onMembershipUpdated }) {
   const { t } = useTranslation('tribes');
 

diff --git a/modules/tribes/client/controllers/tribes-list.client.controller.js b/modules/tribes/client/controllers/tribes-list.client.controller.js
@@ -11,11 +11,11 @@
 
     // Exposed to the view
     vm.user = Authentication.user;
-    vm.broadcastChange = function (data) {
-      if (data.tribe) {
-        $rootScope.$broadcast('tribeUpdated', data.tribe);
-      }
 
+    /**
+     * Update the Authentication.user with updated tribe membership
+     */
+    vm.broadcastUpdatedUser = function (data) {
       if (data.user) {
         Authentication.user = data.user;
         $rootScope.$broadcast('userUpdated');
@@ -24,7 +24,6 @@
 
     /**
      * Emit photo credits info
-     * @TODO remove this
      */
     vm.addPhotoCredits = function addPhotoCredits(photo) {
       $scope.$emit('photoCreditsUpdated', photo);

diff --git a/modules/tribes/client/views/tribes-list.client.view.html b/modules/tribes/client/views/tribes-list.client.view.html
@@ -2,5 +2,5 @@
   user="app.user"
   onDisplayPhoto="tribesList.addPhotoCredits"
   onHidePhoto="tribesList.removePhotoCredits"
-  onMembershipUpdated="tribesList.broadcastChange"
+  onMembershipUpdated="tribesList.broadcastUpdatedUser"
 ></tribes-page>