Plugin Audio Streaming CPU/Memory Usage Reduction #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for contributing the Plugin code - it has been working out great. Hopefully I didn't mess things up too much when I integrated it. This fix is a great idea. Should it be a single setting at the top level for the whole instance? Or done system by system? |
|
No problem. I switched jobs and haven't had time to work on anything else for a while. I've got some time now, so I figured I would take a look. It looks great, and I have a few ideas that may help (i.e. when to delete the wav files). For this I think you are correct and it should be a global flag. Individually, it should be on the system, not the source. Global makes more sense. |
I moved the enable audio out of the Source and it is just stored right in the recorder now.
|
@aaknitt heads up on this incoming change. Streaming audio will be off by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the audio streaming callbacks to be turned off if they are not being used. This reduces the memory and CPU usage. On RaspberryPi3 and other small devices, this can add significant overhead on a feature that is not commonly used.