-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version check and calls to cmake_minimum_required() (#522) #523
Add version check and calls to cmake_minimum_required() (#522) #523
Conversation
This addresses an issue where Kokkos updates the KokkosConfig_install.cmake file to use 'if (... IN_LIST ...)'. NOTE: There is no test in TriBITS that checks for this change because the TriBITS-generated <Package>Config.cmake and <Project>Config.cmake files don't use 'if (... IN_LIST ...)'. I had to manually test this against Trilinos to verify this makes the error go away. All that the TriBITS testing does is ensure that this change does not break these files for the TriBITS use cases.
@KyleFromKitware, can you please give this a quick review. I might merge and allow you to do a post-merge review depending on how my Trilinos testing goes. I want to get a Trilinos PR with an updated TriBITS 'master' posted as soon as I can. |
I tested this against Trilinos branch and version:
on 'crf450' with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go ahead and allow the merge so that I can get a Trilinos PR put up so it can be tested overnight.
@KyleFromKitware, can you please do a post-merge review of this PR? |
…REQUIRED (TriBITSPub#522) This was changed from the open-ended ${CMAKE_VERSION}. This way, we allow CMake to use a more current set of policies while not writting future futures of CMake a blank check. This change was made based on feedback from @KyleFromKitware from the post-merge review of TriBITSPub#523. NOTE: I manaully tested this with a configure of Trilinos and it produded: cmake_minimum_required(VERSION 3.3...3.17.0)
Addresses #522. See git commit log msg for more details.