Implement disable of subpackages tests/examples based on parent disables (#268) #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f0b4f0 to
acdd4c7
Compare
|
Hello @KyleFromKitware, when you get a chance, can you please give this a review? It is not a very big PR (and almost all of the code is documentation and tests). |
This shows the behavior that is more logical for <ParentPackage>_ENABLE_[TESTS|EXAMPLES]=OFF setting default for <ParentPackage><Spkg>_ENABLE_[TESTS|EXAMPLES]=OFF.
…les (#268) This makes it so that setting <ParentPackage>_ENABLE_[TESTS|EXAMPLES]=OFF will set the default for its subpackages <ParentPackage><Spkg>_ENABLE_[TESTS|EXAMPLES]=OFF.
acdd4c7 to
3057012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See git log msgs and updated documentation for details