Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TribitsExampleProject readme fix #441

Merged
merged 3 commits into from
Jan 28, 2022
Merged

TribitsExampleProject readme fix #441

merged 3 commits into from
Jan 28, 2022

Conversation

marcinwrobel1986
Copy link
Collaborator

This PR:

  • updated README.md for TribitsExampleProject

@marcinwrobel1986 marcinwrobel1986 self-assigned this Jan 27, 2022
bartlettroscoe
bartlettroscoe requested changes Jan 27, 2022
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was definingly a typo but the correct path based on the assumed directory structure is ../../TribitsExampleProject.

@bartlettroscoe
Change to not assume a directory structure
92274d3 
This uses <build-dir> and <path-to-TribitsExampleProject> that can exist anywhere 
(they just can't be the same dir).
@bartlettroscoe
Copy link
Member

@marcinwrobel1986, please take a look at the updated README.md file. Hopefully that will do the trick.

@bartlettroscoe bartlettroscoe self-requested a review January 28, 2022 15:47
marcinwrobel1986
marcinwrobel1986 commented Jan 28, 2022
View reviewed changes
Copy link
Collaborator Author

@marcinwrobel1986 marcinwrobel1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good:) agree, thanks!

bartlettroscoe
bartlettroscoe approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good:) agree, thanks!

@marcinwrobel1986, thanks for the feedback to improve this!

@bartlettroscoe bartlettroscoe merged commit d374a38 into TriBITSPub:master Jan 28, 2022
@bartlettroscoe bartlettroscoe mentioned this pull request Mar 7, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

Assignees

@marcinwrobel1986 marcinwrobel1986

Labels
None yet
Projects
TriBITS Refactor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcinwrobel1986 @bartlettroscoe