Add generic override for the c standard #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the TRIBITS_DEFINE_STANDARD_COMPILE_FLAGS_VARS
macro to respect a ${PROJECT_NAME}_C_Standard value when passed.
|
I think I might should have sent this to another repo than TriBITSPub - let me know if I forked the wrong one. Thanks! Paul |
prwolfe
added a commit
to prwolfe/Trilinos
that referenced
this pull request
Nov 8, 2017
This file should be merged to Trilinos only after pull request trilinos#239 in TriBITSPub has been propigated to Trilinos. (TriBITSPub/TriBITS#239) It merely sets the override for the sierra builds to be the c11 posix standard.
|
@prwolfe, this is the right repo. I will look at a way to write a test for this and add documentation then I will push to your branch. |
There is no C code in TribitsExampleProject so I could not set up a direct
test for the correct setting of the cache var ${PROJECT_NAME}_C_Standard. But
since this is just a small amount of code I tested it with a quick build of
Zoltan under Trilinos (which has *.c files).
I added documentation to the Tribits Developers Guide since it is mostly
project developers who will want to change the C standard. I did not directly
document this new option in the TriBITS Project Build Reference since I did
not think it needed to be documented there. But since this is a cache var,
users can find this by examining the cache vars and the documentation for
those. Hopefully that is enough.
ToDo: We need to add an example/test package that has C code so that we can
test C handling of real source code by TriBITS.
bartlettroscoe
added a commit
that referenced
this pull request
Nov 10, 2017
This is needed for trilinos/Trilinos#1974. Build/Test Cases Summary Enabled Packages: Enabled all Packages 0) MPI_DEBUG => passed: passed=263,notpassed=0 (0.74 min) 1) SERIAL_RELEASE => passed: passed=263,notpassed=0 (0.62 min) 2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=284,notpassed=0 (0.62 min) 3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=284,notpassed=0 (0.53 min) Other local commits for this build/test group: 6e3d7d2, f22a20e, 09cc5c4
bartlettroscoe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Nov 10, 2017
Allows override of --std=<cstd> for compiling C files (TriBITSPub/TriBITS#239) Build/Test Cases Summary Enabled Packages: Disabled Packages: PyTrilinos,Claps,TriKota Enabled all Packages 0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=2501,notpassed=0 (105.92 min) Other local commits for this build/test group: e8ab9eb
prwolfe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Nov 13, 2017
This file should be merged to Trilinos only after pull request #239 in TriBITSPub has been propigated to Trilinos. (TriBITSPub/TriBITS#239) It merely sets the override for the sierra builds to be the c11 posix standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the TRIBITS_DEFINE_STANDARD_COMPILE_FLAGS_VARS
macro to respect a ${PROJECT_NAME}_C_Standard value when passed.