Colorize git commands run through gitdist #205
Conversation
When opening a subprocess and passing the stdout to PIPE, the output is buffered, losing the colors otherwise seen when running the command from the command line. One solution to keeping the colors is to redirect the stdout and stderr of the subprocess to the stdout and stderr of the main process. Calling communicate() then makes the call block until the end of the subprocess, otherwise gitdist would continue while the previous git command was finishing, leading to interspersed lines of output.
|
This is so odd, but I never got an email from GitHub about the creation of this issue! Is GitHub broken or something? Is the SNL system filtering these emails as spam? What is going on? |
@bartlettroscoe, I'm not sure. I was messing with my notification settings last week to try to decrease the number of emails I get, and I think at this point I don't get any notifications from Trilinos or TriBITS, so I'm probably not the best person to ask. Except I just got an email with your last comment, so now I'm rather confused. |
With the change in the runCmnd() function, you need to add a print("")
statement to keep two blank lines after the end of the command and the next
git repo header output. I think having two newlines is a good separator
between git repo output.
|
The commit 0518ce8 I just pushed fixes the gitdist test suite with Python 2.6.6. I will go ahead and merge and push this to the 'master' branch. Thanks for fixing this! It has annoyed me for a long time that running gitdist removed color (but color still gets removed when I pipe it into |
Addresses #205 Build/Test Cases Summary Enabled Packages: Enabled all Packages 0) MPI_DEBUG => passed: passed=246,notpassed=0 (0.62 min) 1) SERIAL_RELEASE => passed: passed=246,notpassed=0 (0.61 min) 2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=265,notpassed=0 (0.66 min) 3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=265,notpassed=0 (0.50 min) Other local commits for this build/test group: 0518ce8, fcb7ac2
That's because command output gets buffered as it's sent through the pipe. Command line fixes for that include prepending your command with |
It was bugging me that
gitdiststripped out whatever colors would normally be displayed when running the equivalentgitcommands from the command line. This is an attempt to fix that problem by tying thestdoutandstderrof thesubprocessused to execute thegitcommand to thestdoutandstderrof the process runninggitdistitself. Not sure if that's the best way to do this—I only have about an hour's worth of experience with Python'ssubprocess. I haven't seen any unintended side effects of this change yet, though I am by no means a powergitdistuser. Let me know if this just isn't a good idea, or if we need to go about it a different way. Many thanks.