Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRIBITS_CTEST_DRIVER() does not pass through disables in ${PROJECT_NAME}_EXCLUDE_PACKAGES when ${PROJECT_NAME}_EANBLE_ALL_PACKAGES=ON is set in all-at-once mode. #269

Closed
bartlettroscoe opened this issue Oct 11, 2018 · 2 comments
Closed

TRIBITS_CTEST_DRIVER() does not pass through disables in ${PROJECT_NAME}_EXCLUDE_PACKAGES when ${PROJECT_NAME}_EANBLE_ALL_PACKAGES=ON is set in all-at-once mode. #269

bartlettroscoe opened this issue Oct 11, 2018 · 2 comments
Assignees
@bartlettroscoe
Labels
component: ctest_driver type: bug

Comments

@bartlettroscoe
Copy link
Member

When Trilinos switched over to use the all-at-once mode by default for all builds (as part of the CMake 3.10 upgrade, see trilinos/Trilinos#1761), it exposed a defect for builds that set ${PROJECT_NAME}_EANBLE_ALL_PACKAGES=ON and ${PROJECT_NAME}_EXCLUDE_PACKAGES=<pkg0>,<pkg1>,... in all-at-once mode. The problem is that TRIBITS_CTEST_DRIVER() passes through ${PROJECT_NAME}_EANBLE_ALL_PACKAGES=ON but not the packages listed in ${PROJECT_NAME}_EXCLUDE_PACKAGES. This resulted in them being enabled in the inner configure where they failed to configure (PyTrilinos in that case, see trilinos/Trilinos#1761 (comment)).
@bartlettroscoe bartlettroscoe self-assigned this Oct 11, 2018
@bartlettroscoe bartlettroscoe mentioned this issue Oct 11, 2018
Closed
bartlettroscoe added a commit that referenced this issue Oct 11, 2018
@bartlettroscoe
TRIBITS_CTEST_DRIVER(): Correctly pass in excluded package disables f…
373c6d2 
…or all-at-once approach (#269)

This was needed when switching from the package-by-package appraoch to the
all-at-once approach by default in Trilinos.  See trilinos/Trilinos#1761.

I also made it so that the list passed in to <Project>_EXCLUDE_PACAKGES can be
seprated by commas ',' or semi-colons ';'.

I added a unit test that protects both of these two behaviors.

Build/Test Cases Summary
Enabled Packages:
Enabled all Packages
0) MPI_DEBUG => passed: passed=329,notpassed=0 (0.81 min)
1) SERIAL_RELEASE => passed: passed=329,notpassed=0 (0.88 min)
@bartlettroscoe bartlettroscoe mentioned this issue Oct 11, 2018
Merged
4 tasks
@bartlettroscoe
Copy link
Member Author

Commit 373c6d2 should fix this and it is pushed to 'master' and I snapshotted this to Trilinos in trilinos/Trilinos#3610.

Putting in review.

@bartlettroscoe
Copy link
Member Author

This fixed the issue raised in trilinos/Trilinos#1761 (comment).

Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlettroscoe bartlettroscoe

Labels
component: ctest_driver type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartlettroscoe