Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TriBITS_gitdist_UnitTests move-to-base-dir tests failing on Travis C #247

Closed
bartlettroscoe opened this issue Jan 4, 2018 · 2 comments
Closed

TriBITS_gitdist_UnitTests move-to-base-dir tests failing on Travis C #247

bartlettroscoe opened this issue Jan 4, 2018 · 2 comments
Assignees
@bartlettroscoe
Labels
component: python_utils type: bug

Comments

@bartlettroscoe
Copy link
Member

At some point, test TriBITS_gitdist_UnitTests started failing with some of the 'move-to-base-dir' tests failing. The failing using tests are all related to the 'move-to-base-dir' feature. The unit test output looks like:

..
test_gitdist_move_to_base_dir (__main__.test_gitdist) ... FAIL
test_gitdist_move_to_base_dir_no_dist_gitdist_file (__main__.test_gitdist) ... FAIL
======================================================================
FAIL: test_gitdist_move_to_base_dir (__main__.test_gitdist)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/TriBITSPub/TriBITS/test/python_utils/gitdist_UnitTests.py", line 1554, in test_gitdist_move_to_base_dir
    self.assertEqual(s(cmndOut), s(cmndOut_expected))
AssertionError: "\n*** Base Git Repo: TriBITS\n['mockgit', 'status']\n\n" != "\n*** Base Git Repo: MockProjectDir\n['mockgit', 'status']\n\n*** Git Repo: ExtraRepo\n['mockgit', 'status']\n\n"

======================================================================
FAIL: test_gitdist_move_to_base_dir_no_dist_gitdist_file (__main__.test_gitdist)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/TriBITSPub/TriBITS/test/python_utils/gitdist_UnitTests.py", line 1614, in test_gitdist_move_to_base_dir_no_dist_gitdist_file
    self.assertEqual(s(cmndOut), s(cmndOut_expected))
AssertionError: "\n*** Base Git Repo: TriBITS\n['mockgit', 'status']\n\n" != "\n*** Base Git Repo: somewhere\n['mockgit', 'status']\n\n"

----------------------------------------------------------------------
Ran 53 tests in 2.850s

FAILED (failures=2)
('cmndOut = ', "Error, env var GITDIST_MOVE_TO_BASE_DIR='INVALID' is invalid!  Valid choices include empty '', IMMEDIATE_BASE, and EXTREME_BASE.\n")
('cmndOut_expected = ', "Error, env var GITDIST_MOVE_TO_BASE_DIR='INVALID' is invalid!  Valid choices include empty '', IMMEDIATE_BASE, and EXTREME_BASE.\n")
@bartlettroscoe bartlettroscoe self-assigned this Jan 4, 2018
@bartlettroscoe
Copy link
Member Author

I bet I know what the problem is. The Travis CI build creates the build dir under the TriBITS project source dir. This changes the behavior of the tests since now the base-most .gitdist.default file is in the base TriBITS/ source dir, not in the test dir. Seems like the gitdist command should be given a max depth argument or something to stop gitdist from looking too deep. But for now, I will just have Travis CI remove the base TriBITS/.gitdist.default file and see if that fixes the problem.

bartlettroscoe added a commit that referenced this issue Jan 4, 2018
@bartlettroscoe
Remove base .gitdist.default file for Travis CI testing (#247)
20e4a08 
This is a stop-gap to avoid the tests that look for the base-most
.gitdist.default file.
bartlettroscoe added a commit that referenced this issue Jan 4, 2018
@bartlettroscoe
Create build dir not under source tree for Travis CI (#247)
b27fe0e 
This should avoid tests that look for the base-most .gitdist.default file
getting messed up by having the build dir under TriBITS/ soruce dir.
bartlettroscoe added a commit that referenced this issue Jan 4, 2018
@bartlettroscoe
Create build dir not under source tree for Travis CI (#247)
005b906 
This should avoid tests that look for the base-most .gitdist.default file
getting messed up by having the build dir under TriBITS/ soruce dir.
bartlettroscoe added a commit that referenced this issue Jan 4, 2018
@bartlettroscoe
Create build dir not under source tree for Travis CI (#247)
1ef4e3d 
This should avoid tests that look for the base-most .gitdist.default file
getting messed up by having the build dir under TriBITS/ soruce dir.

Build/Test Cases Summary
Enabled Packages:
Enabled all Packages
0) MPI_DEBUG => passed: passed=266,notpassed=0 (0.81 min)
1) SERIAL_RELEASE => passed: passed=266,notpassed=0 (0.63 min)
2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=287,notpassed=0 (0.56 min)
3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=287,notpassed=0 (0.54 min)
Other local commits for this build/test group: 3d3308e, f8d7208
@bartlettroscoe
Copy link
Member Author

My commit 1ef4e3d just pushed to master seems to have fixed this test as shown at:

Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlettroscoe bartlettroscoe

Labels
component: python_utils type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartlettroscoe