-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No such file or directory: TribitsBuildReference.html #242
Comments
@wfspotz, thanks for passing this along. It looks like that symlink got committed by default. I will remove the symlink from TriBITS and we can update the Trilinos 12.12 branch to not have this file. |
Actually, that file is not in TriBITS. What likely happened is that that file just happened to be in the source TriBITS repo and it got copied over during the snapshot and then it did not get ignored in the target Trilinos git repo. I will fix this and explain in those commits. |
…TriBITSPub/TriBITS#242) The current TriBITS snapshotting script (which just uses `rsync --delete`) copies all files from TriBITS/tribits/ over to Trilinos/cmake/tribits/ and then commits all of the non-ignored files. What happened is there there is not a committed ignore for this file in the TriBITS/tribits/doc/developers_guilde/.gitignore file. Instead, there was a local ignore in the source TriBITS/ repo for this file. The solution for this is file TribitsBuildReference.html is to put in an ignore for this in the source TriBITS/tribits/doc/developers_guilde/.gitignore file so the next time the snapshot of TriBITS occurs. I will do that in the TriBITS github repo.
…TriBITSPub/TriBITS#242) The current TriBITS snapshotting script (which just uses `rsync --delete`) copies all files from TriBITS/tribits/ over to Trilinos/cmake/tribits/ and then commits all of the non-ignored files. What happened is there there is not a committed ignore for this file in the TriBITS/tribits/doc/developers_guilde/.gitignore file. Instead, there was a local ignore in the source TriBITS/ repo for this file. The solution for this is file TribitsBuildReference.html is to put in an ignore for this in the source TriBITS/tribits/doc/developers_guilde/.gitignore file so the next time the snapshot of TriBITS occurs. I will do that in the TriBITS github repo.
@bartlettroscoe OK, thanks for looking into this. Between now and the next update of the Trilinos 12.12 tarball, I will need to find a workaround. It looks to me like if, before my conda recipe does a
and I should be good. |
The script snapshot-dir.py now, by default, cleans out git ignored files in the orig-dir/. This is done so that files that may only have local git ignores (i.e. in .git/info/excludes) in the orig-dir don't get copied into and commited in the dest-dir. This will resolve issues where a temp ignored file in the orig-dir is accidentally copied and committed to the dest-dir repo as reported in #242. Build/Test Cases Summary Enabled Packages: Enabled all Packages 0) MPI_DEBUG => passed: passed=263,notpassed=0 (0.72 min) 1) SERIAL_RELEASE => passed: passed=263,notpassed=0 (0.61 min)
After some more thought, I realized that turning on the cleaning of ignored files from the orig-dir by default was just a bit too dangerous. I would rather that too much get synced by accident by people who are just starting to use this script than to have the script delete a bunch of files and directroies from the orig-dir that the user was depending on and will get very angry if those files got deleted. I updated the automated tests to run with both cases and updated the documentation for the new default behavior. Build/Test Cases Summary Enabled Packages: Enabled all Packages 0) MPI_DEBUG => passed: passed=263,notpassed=0 (0.79 min) 1) SERIAL_RELEASE => passed: passed=263,notpassed=0 (0.59 min) 2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=284,notpassed=0 (0.63 min) 3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=284,notpassed=0 (0.51 min)
I decided to create a script to further simplify the process of snapshotting TriBITS into Trilins. This makes sure the snapshotting is always run from the right directories. But the main reason that I added this script was to make sure that the new option --clean-ignored-files-orig-dir is used. That ensures that we don't accidentally copy over locally ingored files like happened with the file: cmake/tribits/doc/developers_guide/TribitsBuildReference.html as described in TriBITSPub/TriBITS#242.
…TS#242) * Updated TriBITS snapshot_tribits.py script to clean ignored files from orig-dir. This will avoid issues like TriBITSPub/TriBITS#242 in the future.
FYI: I changed the snapshot-dir.py script to not clean the ignored files out of orig-dir by default after some thought. I added as script to Trilinos to drive the snapshot with the new option Hopefully others using this script will do the same. |
- add boost-cpp dep - add workaround for tribits: TriBITSPub/TriBITS#242
I am trying to upgrade the conda installer for Trilinos to release version 12.12.1. The build process downloads the 12.12.1 tarball and builds, gets almost to the end where it says it is "Fixing permissions", and fails with
I checked the file, and it is a symbolic link to
../build_ref/TribitsBuildReference.html
. I checked that file, and it does not exist (although a couple ofTribitsBuildReference*.rst
files do exist).The text was updated successfully, but these errors were encountered: