Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend TriBITS to allow for Kokkos compiler and env config settings #207

Closed
bartlettroscoe opened this issue Jul 14, 2017 · 2 comments
Closed

Extend TriBITS to allow for Kokkos compiler and env config settings #207

bartlettroscoe opened this issue Jul 14, 2017 · 2 comments
Assignees
@kruger
Labels
component: core

Comments

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Jul 14, 2017 •
edited
Loading

CC: @kruger

See trilinos/Trilinos#1400

ToDo: Fill in details
bartlettroscoe added a commit that referenced this issue Jul 14, 2017
@bartlettroscoe
WIP: Start to some ideas (#207)
63dcdf6
@bartlettroscoe bartlettroscoe mentioned this issue Jul 14, 2017
Closed
bartlettroscoe added a commit that referenced this issue Jul 17, 2017
@bartlettroscoe
WIP: Fix typo EXITS (#207)
8644ef4
@bartlettroscoe
Copy link
Member Author

@kruger,

After you accept the collaborator invite I just sent you for this project, please implement what we discussed on Friday by pushing new commits to the branch:

We will need to also create a parallel Trilinos branch as part of trilinos/Trilinos#1400 if we go with the

After we have all of this working on branches, we can clean the branches up (i.e. squash and reorganize commits with git rebase -i) and then push to the various repos (except Kokkos which will just be a PR). Actually, we can directly push to the Trilinos/packages/kokkos/ dir after we post the PR. We can discuss how this works.

kruger added a commit that referenced this issue Oct 10, 2017
@kruger
Enable post-processing of config of compilers
58eef70 
Enable including a project-level file (`cmake/ProjectCompilerPostConfig.cmake`)
for adding additional flags, or defining other variables.  Motivated by
better Kokkos/Trilinos integration discussed in Issue #207
kruger added a commit that referenced this issue Oct 18, 2017
@kruger
Enable post-processing of config of compilers
5fd7e28 
Enable including a project-level file (`cmake/ProjectCompilerPostConfig.cmake`)
for adding additional flags, or defining other variables.  Motivated by
better Kokkos/Trilinos integration discussed in Issue #207
bartlettroscoe added a commit that referenced this issue Nov 30, 2017
@bartlettroscoe
WIP: Add trace for the include of the file (#207)
a337dbe
bartlettroscoe added a commit that referenced this issue Nov 30, 2017
@bartlettroscoe
Add test for include of ProjectCompilerPostConfig.cmake (#207)
e476b0e 
This is a very strong yet very portable test that ensures that the file
cmake/ProjectCompilerPostConfig.cmake gets included and it is able to modify
CMAKE_CXX_FLAGS.
bartlettroscoe pushed a commit that referenced this issue Nov 30, 2017
@kruger @bartlettroscoe
Enable post-processing of config of compilers (#207, trilinos/Trilino…
6fa3d69 
…s#1400)

Enable including a project-level file:

  cmake/ProjectCompilerPostConfig.cmake

for adding additional flags, or defining other variables.  Motivated by better
Kokkos/Trilinos integration (see trilinos/Trilinos#1400).
bartlettroscoe added a commit that referenced this issue Nov 30, 2017
@bartlettroscoe
Add test for include of ProjectCompilerPostConfig.cmake (#207)
e3d86d5 
This is a very strong yet very portable test that ensures that the file
cmake/ProjectCompilerPostConfig.cmake gets included and it is able to modify
CMAKE_CXX_FLAGS.
bartlettroscoe added a commit that referenced this issue Nov 30, 2017
@bartlettroscoe
Merge branch 'kokkos-config-207' (#207, trilinos/Trilinos#1400)
1fd597c 
Build/Test Cases Summary
Enabled Packages:
Enabled all Packages
0) MPI_DEBUG => passed: passed=265,notpassed=0 (0.68 min)
1) SERIAL_RELEASE => passed: passed=265,notpassed=0 (0.61 min)
2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=286,notpassed=0 (0.63 min)
3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=286,notpassed=0 (0.58 min)
Other local commits for this build/test group: e3d86d5, 6fa3d69
@bartlettroscoe
Copy link
Member Author

I merged the PR #233 for the branch kokkos-config-207. I rebased and squashed the commits and added a new commit to add automated testing for this feature (to make sure the feature does not get broken).

I am going to close this story. The non-trivial code in in Triinos (see trilinos/Trilinos#1400) and Kokkos (see kokkos/kokkos#878).

bartlettroscoe added a commit that referenced this issue Dec 2, 2017
@bartlettroscoe
Add documentation for ProjectCompilerPostConfig.camke (#207)
9e648ac
bartlettroscoe added a commit that referenced this issue Jan 26, 2018
@bartlettroscoe
Fix spelling of dummy define (#207)
ee4073b 
Fixed the spelling of DUMMY_DEFINE_JUST_TO_TEST_COMILER_POST_CONFIG.

I also switched from 'make VERBOSE=1' to -DCMAKE_VERBOSE_MAKFILE=ON in hopes
of fixing a strange test failure when doing a dashboard sumbit.  But this did
not fix the problem.  I have not idea why the comiler is not being verbose
when running the dashboard build vs. locally.

Build/Test Cases Summary
Enabled Packages:
Enabled all Packages
0) MPI_DEBUG => passed: passed=266,notpassed=0 (0.74 min)
1) SERIAL_RELEASE => passed: passed=266,notpassed=0 (0.59 min)
2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=287,notpassed=0 (0.61 min)
3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=287,notpassed=0 (0.54 min)
Other local commits for this build/test group: 87f4562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kruger kruger

Labels
component: core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kruger @bartlettroscoe