Skip to content

Commit

Permalink
Fix failing TriBITS tests on anasova for HEAVY build (PHI #3913)
Browse files Browse the repository at this point in the history
I fixed two things here:

* The test AAO_ST_ALL_BreakWithSubpackagesALib was failing due to the
  MixedLang package showing build failures for this build.  This is very
  strange and suggests some behavior I don't understand.

* Explictly set CTEST_PARALLEL_LEVEL in env.  It was assuming the default of
  '1' but the HEAVY suite sets this to 48 in the env and was missing up the
  test.  Now it is explicit.  (This is the problem with env vars, they drill
  through everything.)
  • Loading branch information
bartlettroscoe committed Oct 18, 2017
1 parent b3354b4 commit 1465992
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions test/ctest_driver/TribitsExampleProject/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ SET(PBP_COMMON_ENV_ARGS
CTEST_ENABLE_MODIFIED_PACKAGES_ONLY=OFF
TribitsExProj_PRE_REPOSITORIES=
TribitsExProj_EXTRA_REPOSITORIES=
CTEST_BUILD_FLAGS=-j2
CTEST_PARALLEL_LEVEL=1
# Other args
TribitsExProj_TRIBITS_DIR=${${PROJECT_NAME}_TRIBITS_DIR}
TribitsExProj_EXTRAREPOS_FILE=NONE
Expand Down Expand Up @@ -734,6 +736,7 @@ FUNCTION(GENERATE_AAO_TESTS USE_NEW_AAO_CTEST_CDASH_FEATURES)
ARGS
CTEST_DASHBOARD_ROOT=PWD
${AAO_COMMON_ENV_ARGS}
CTEST_PARALLEL_LEVEL=3
TribitsExProj_ENABLE_SECONDARY_TESTED_CODE=TRUE
${CTEST_DROP_SITE_ENV_ARGS}
CTEST_BUILD_NAME=${PACKAGE_NAME}_CTestDriver_AAO${AAO_POSTFIX}_ST_ALL_PASS
Expand All @@ -752,7 +755,7 @@ FUNCTION(GENERATE_AAO_TESTS USE_NEW_AAO_CTEST_CDASH_FEATURES)
"Building all targets [.][.][.]"
"Build output: BUILD_ALL_NUM_ERRORS='0',BUILD_ALL_RETURN_VAL='0'"
"Build PASSED"
"Running tests .parallel level 1."
"Running tests .parallel level 3."
"SimpleCxx_HelloWorldTests [.]+ +Passed"
"SimpleCxx_HelloWorldProg [.]+ +Passed"
"WithSubpackagesA_test_of_a [.]+ +Passed"
Expand Down Expand Up @@ -979,7 +982,7 @@ FUNCTION(GENERATE_AAO_TESTS USE_NEW_AAO_CTEST_CDASH_FEATURES)
"WithSubpackagesC_test_of_c_b_mixed_lang [.]+[*][*][*]Not Run"
"WrapExternal_run_external_func [.]+[*][*][*]Not Run"
"File '.+/${PACKAGE_NAME}_CTestDriver_AAO${AAO_POSTFIX}_ST_ALL_BreakWithSubpackagesALib/BUILD/Testing/Temporary/LastTestsFailed_.+.log' exists so there were non-passing tests"
"Final set packages that had any failures: 'WithSubpackages.*WrapExternal"
"Final set packages that had any failures: '.*WithSubpackages.*WrapExternal"
"TRIBITS_CTEST_DRIVER: OVERALL: ALL FAILED"
ALWAYS_FAIL_ON_ZERO_RETURN
TEST_3
Expand All @@ -998,7 +1001,9 @@ FUNCTION(GENERATE_AAO_TESTS USE_NEW_AAO_CTEST_CDASH_FEATURES)
# is checked to make sure that it is getting written correctly. That is
# important for CI servers.
# NOTE: Above, I had to weaken the test some to get it to pass on th232
# when run with 'make dashboard'.
# when run with 'make dashboard'. I also had to weaken the test for the
# list of list of failed packages because the MixedLang package has
# failures on anasova with 'make dashboard'.

TRIBITS_ADD_ADVANCED_TEST( CTestDriver_AAO${AAO_POSTFIX}_ST_PackagesSubset_BreakWithSubpackagesALib
OVERALL_WORKING_DIRECTORY TEST_NAME
Expand Down

0 comments on commit 1465992

Please sign in to comment.