Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auditing is not working anymore #39

Closed
rmaihge opened this issue Nov 3, 2023 · 7 comments
Closed

Auditing is not working anymore #39

rmaihge opened this issue Nov 3, 2023 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@rmaihge
Copy link

rmaihge commented Nov 3, 2023

Hello,

Using the latest version of kube-oidc-proxy the auditing is not working anymore.

Please check my setup for running the application:
`
root@oidc-proxy-kube-oidc-proxy-5fdb8f4d78-wkc9q:/# ps -ef|grep oidc
root 1 0 0 13:03 ? 00:00:06 kube-oidc-proxy --secure-port=443 --tls-cert-file=/etc/oidc/tls/crt.pem --tls-private-key-file=/etc/oidc/tls/key.pem --oidc-client-id=xxxxxxxx --oidc-issuer-url=https://example.com --oidc-username-claim=sub --oidc-ca-file
=/etc/oidc/oidc-ca.pem --oidc-groups-claim=groups --oidc-signing-algs=RS256 --audit-log-path=/dev/stdout --audit-policy-file=/audit/audit.yaml

root@oidc-proxy-kube-oidc-proxy-5fdb8f4d78-wkc9q:/# cat audit/audit.yaml
apiVersion: audit.k8s.io/v1
kind: Policy
rules:

  • level: RequestResponse
    `

It is not clear for me from what version is this happening.

Can you please check and advice?

Thank you!

@mlbiam
Copy link

mlbiam commented Nov 3, 2023

i'll take a look. we've informally deprecated the audit capability, with the thinking that it's much better to be done that the API server layer anyways. What are you looking to get out of kube-oidc-proxy for audit that the API server doesn't have?

@rmaihge
Copy link
Author

rmaihge commented Nov 6, 2023

The kube-oidc-proxy audit logging was at hand and I didn't need to make changes at the fluentd/fluentbit logging solution.

@mlbiam
Copy link

mlbiam commented Nov 25, 2023

@rmaihge can you please provide your full policy file? i'm looking at this now. hoping to include whatever fix is needed in the release i'm working on now

@rmaihge
Copy link
Author

rmaihge commented Nov 27, 2023

The policy file used is:

    apiVersion: audit.k8s.io/v1
    kind: Policy
    rules:
    - level: RequestResponse

mlbiam added a commit to mlbiam/kube-oidc-proxy that referenced this issue Nov 28, 2023
…user the user to the impersonated user if impersonation headers sent
@mlbiam
Copy link

mlbiam commented Nov 28, 2023

@rmaihge give ghcr.io/mlbiam/kube-oidc-proxy:1.0.6-8fc6b0 a try. think i got it figured it out.

mlbiam added a commit to mlbiam/kube-oidc-proxy that referenced this issue Nov 28, 2023
@mlbiam mlbiam added the bug Something isn't working label Nov 28, 2023
@mlbiam mlbiam added this to the 1.0.6 milestone Nov 28, 2023
@rmaihge
Copy link
Author

rmaihge commented Dec 5, 2023

Bug solved.
Thank you!

@rmaihge rmaihge closed this as completed Dec 5, 2023
@mlbiam
Copy link

mlbiam commented Dec 5, 2023

This fix was included in the 1.0.6 release that was cut last week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants