Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-70 Fix Unequal length row/column merge and conflict with thead/tfoot #11

Merged
merged 3 commits into from
May 2, 2024
Merged

WP-70 Fix Unequal length row/column merge and conflict with thead/tfoot #11

merged 3 commits into from
May 2, 2024

Conversation

i-am-chitti
Copy link
Member

Description

This PR fixes these -

  1. Before merging, there is a check added to validate that the columns/rows to be merged are of equal length.
  2. The tbody's first row merging is being conflicted with the thead elements.

@i-am-chitti i-am-chitti self-assigned this May 2, 2024
@i-am-chitti i-am-chitti requested a review from junaidbhura May 2, 2024 19:22
@junaidbhura junaidbhura merged commit 06e9605 into master May 2, 2024
1 check passed
@junaidbhura junaidbhura deleted the WP-70/fix-merging branch May 2, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaidbhura junaidbhura junaidbhura approved these changes

Assignees

@i-am-chitti i-am-chitti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-am-chitti @junaidbhura