Merge pull request #12 from TransitApp/dont_introduce_default_0s

dont put default value on optional fields
TransitApp · Oct 25, 2022 · 443f335 · 443f335
2 parents f57fac9 + 5665bcd
commit 443f335
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/gtfs_loader/schema.py b/gtfs_loader/schema.py
@@ -95,11 +95,11 @@ class BookingRule(Entity):
 
     booking_rule_id: str
     booking_type: BookingType
-    prior_notice_duration_min: int = 0
-    prior_notice_duration_max: int = 0
-    prior_notice_last_day: int = 0
+    prior_notice_duration_min: Optional[int] = None
+    prior_notice_duration_max: Optional[int] = None
+    prior_notice_last_day: Optional[int] = None
     prior_notice_last_time: GTFSTime = GTFSTime('')
-    prior_notice_start_day: int = 0
+    prior_notice_start_day: Optional[int] = None
     prior_notice_start_time: GTFSTime = GTFSTime('')
     prior_notice_service_id: str = ''
     message: str = ''

diff --git a/setup.py b/setup.py
@@ -1,7 +1,7 @@
 from setuptools import setup, find_packages
 
 setup(name='py-gtfs-loader',
-      version='0.1.5',
+      version='0.1.6',
       description='Load GTFS',
       url='https://github.com/TransitApp/py-gtfs-loader',
       author='Nicholas Paun, Jonathan Milot',