Export objects in fields when exporting csv #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcamp
approved these changes
Apr 27, 2018
helpers/csv.js
Outdated
| @@ -11,7 +11,10 @@ function formatRegularValue(value) { | |||
| return ''; | |||
| } | |||
|
|
|||
| value = (typeof value === 'string') ? value : String(value); | |||
| const type = typeof value; | |||
| value = (type === 'object') ? JSON.stringify(value) : ( | |||
There was a problem hiding this comment.
Fix works but formatting is not ideal, would do two ifs in this case
lvancraen
reviewed
Apr 27, 2018
|
Yeah, we do that for ACTIONAU Canberra for example. I will remove the JSON.stringify in USD 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.