Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle extra double quotes when empty value #13

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Fix: handle extra double quotes when empty value #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f2eac5
Fix: handle extra double quotes when empty value
iliasbhal Feb 6, 2019
b8bd978
Fix: match csv spec, RFC4180 - 7
iliasbhal Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion helpers/csv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ function fromCsvStringToArray(string, tableName) {
}

if (!reValid.test(string)) {
if (string.match(/""""/)) {

if (string.match(/,"(("")+)",/) ) { // remove all extra double-quote if value should be -> ""
string = string.replace(/,"(("")+)",/g, ',"\\"\\"",');
return fromCsvStringToArray(string, tableName);
} else if (string.match(/""""/) ) {
string = string.replace(/""""/g, '\\"\\"');
return fromCsvStringToArray(string, tableName);
} else if (string.match(/,"""/)) { // Handle the case with 3 " at start/end of string
Expand All @@ -86,6 +90,7 @@ function fromCsvStringToArray(string, tableName) {
string = string.replace(/""/g, '\\"');
return fromCsvStringToArray(string, tableName);
}

process.notices.addWarning(__filename, `Row not valid in table ${tableName}: ${string}`);
return [];
}
Expand Down