Add GTFS object #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcamp
reviewed
Dec 29, 2017
helpers/csv.js
Outdated
| return null; | ||
| } | ||
|
|
||
| if (string.includes('"') === false) { |
helpers/export.js
Outdated
| const deepness = schema.deepnessByTableName[tableName]; | ||
| let sampleItem; | ||
|
|
||
| if (deepness === 0) { |
There was a problem hiding this comment.
Why not have a while loop in deepness instead?
There was a problem hiding this comment.
IMHO it is not worth having to think about the while do or do while choice.
helpers/import.js
Outdated
| const rows = []; | ||
| let rowsSlice; | ||
| let position = 0; | ||
| const length = 50000; |
helpers/import.js
Outdated
|
|
||
| if (sortedKeys.length !== arrayOfValues.length) { | ||
| if (process.notices && process.notices.addWarning) { | ||
| process.notices.addWarning(`Row not valid in table: ${JSON.stringify(item)}`); |
There was a problem hiding this comment.
How do you intend to make this work in a public repo?
There was a problem hiding this comment.
Meaning, it will work but not sure that should be public at all?
added 2 commits
December 29, 2017 11:43
quentin-sommer
requested changes
Dec 29, 2017
package.json
Outdated
| "description": "A Node.js librairie for GTFS", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "./node_modules/.bin/mocha tests.js" |
There was a problem hiding this comment.
npm scripts already have the package context in them you can use mocha here
.gitignore
Outdated
| @@ -57,3 +57,5 @@ typings/ | |||
| # dotenv environment variables file | |||
| .env | |||
|
|
|||
| package-lock.json | |||
| .idea/* | |||
quentin-sommer
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the old code used by our internal UpdateStaticData, with only some small improvements:
lodash, nomoment, onlyasync&fs-extra(&acomb)