Playwright Migration and GitHub Actions for CI #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRJurman
commented
Aug 25, 2024
| @@ -0,0 +1,25 @@ | |||
| name: Tram-Deco Playwright Tests | |||
There was a problem hiding this comment.
This file is almost entirely from the npx playwright install, and is probably the most bare-bones we could probably get this to be.
JRJurman
commented
Aug 25, 2024
Comment on lines
+5
to
+7
| const getTextContent = async (element) => { | ||
| return await element.evaluate((el) => el.textContent); | ||
| }; |
There was a problem hiding this comment.
the default toHaveText does not work as expected with slots that have default content. There is probably an issue to raise in the playwright repository, but for the moment, just using this custom function to evaluate the results of textContent manually.
JRJurman
commented
Aug 25, 2024
| return await element.evaluate((el) => el.textContent); | ||
| }; | ||
|
|
||
| test.describe('Tram-Deco Example Components', () => { |
There was a problem hiding this comment.
this is pretty much a translation of spec.cy.js - I used ChatGPT to migrate one to the other
JRJurman
commented
Aug 25, 2024
| /** | ||
| * @see https://playwright.dev/docs/test-configuration | ||
| */ | ||
| module.exports = defineConfig({ |
There was a problem hiding this comment.
We've left this template pretty much untouched, but may update in the future. For now, this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we were using Cypress for out Automated testing, however it was not possible to trivially run that in CI, and the ergonomics of the automation test were honestly not that great.
This PR migrates the tests to Playwright, which allows for a more straight-forward interface when writing tests and interfacing with Web Components.
Checklist
Version Bump(not required, no source changes)