Fix shell crash

[FedorZaytsev]

I have found an interesting crash when use ShellScriptTouchBarItem. You may get the following exception:

2020-04-19 19:18:45.592073-0700 MTMR[13222:2522041] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[NSConcreteTask terminationStatus]: task still running'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff33e35d07 __exceptionPreprocess + 250
	1   libobjc.A.dylib                     0x00007fff6cb5a5bf objc_exception_throw + 48
	2   Foundation                          0x00007fff364f2336 -[NSConcreteTask terminationStatus] + 175
	3   MTMR                                0x000000010008114f $s4MTMR23ShellScriptTouchBarItemC7executeyS2SF + 1535
	4   MTMR                                0x000000010007f4c1 $s4MTMR23ShellScriptTouchBarItemC18refreshAndScheduleyyF + 401

if you have a script which take a long time to execute and you close the notebook. Probably the reason is that OS X put file system into sleep mode which trigger pipe.fileHandleForReading.readDataToEndOfFile() call to return while application is still running.

In this commit I am probably fixed this bug by using waitUntilExit call and by setting timeout on the script execution (execution timeout is equal to update interval).

P.S. Can maintainer release a new version please? I have features that I heavily rely on, so every time I restart my notebook I need to close distributed MTMR, then open XCode and run MTMR from it.

[bobrosoft]

Hi @FedorZaytsev ,
Seems as I have 2 issues after that change with next preset:

{
    "type": "shellScriptTitledButton",
    "width": 80,
    "refreshInterval": 2,
    "source": {
      "inline": "top -l 2 -n 0 -F | egrep -o ' \\d*\\.\\d+% idle' | tail -1 | awk -F% '{p = 100 - $1; if (p > 30) c = \"\\033[33m\"; if (p > 70) c = \"\\033[30;43m\"; printf \"%s%4.1f%%\\n\", c, p}'"
    },
    "action": "appleScript",
    "actionAppleScript": {
      "inline": "activate application \"Activity Monitor\"\rtell application \"System Events\"\r\ttell process \"Activity Monitor\"\r\t\ttell radio button \"CPU\" of radio group 1 of group 2 of toolbar 1 of window 1 to perform action \"AXPress\"\r\tend tell\rend tell"
    },
    "align": "right",
    "image": {
      "base64":
      "iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAA/1BMVEUAAADaACbYACfYACfjABzXACjYACfXACjYACfYACfYACfYACfdACLYACfXACjYACfVACv/AADXACjYACfYACfXACjYACfXACjaACXYACfYACfVACvYACfYACfZACbZACbYACfYACfZACb/AADYACfYACfVACrXACjVACu/AEDYACfYACfYACfXACjXACjYACfXACjYACfYACfYACfXACjYACfXACjYACfYACfZACbYACfYACfMADPYACfYACfYACfYACfYACfZACbXACjYACfYACfRAC7XACjYACfZACbWACnXACjXACjYACfTACzZACb/AADYACfYACfYACcAAAA+zneGAAAAU3RSTlMAItK+CVPjh3xUxPwPiGDQGAMtSKmN3Vk+wPQG/e26oIJBnwJCdiuAHgTmw+6BX+IgfaqLUvKOW8VKnagK+vBwYrhlc/urCznvhSyUbOEXPAFjGh/ektAAAAABYktHRACIBR1IAAAACXBIWXMAAA3XAAAN1wFCKJt4AAAAB3RJTUUH4ggWETQWgEDcSgAAAqVJREFUWMPtl4ly2jAQhsUNNlcw5r4SICEHLSQhCQRyX73T/u//LpUlLIyxbMAznWmn/0ywo5U+27tr7ZoQuwLBUJidRKIxPhKLRtgxHAoGiLfiQIKdKFCTxjGpQmEDCSC+BiAFpNlJBsgaxyyQYQNpIPUf8AcAOzktD+iaoQJQNI5FoMAGdCCv5XZclpfKFXiqUi5Jllf1mvdyQzW96gigd4h6o+mhRp1O0x3vvwa1VSWeqrZU1Jyeogy01ggSVQsoO/i/gjq9/u6u+2LDXq2jshqLHNCgdsCVwO0NILdi0oDmuoAmoImhQDzFRPNnb36L7U43NVfc2EH2D9h5t9OePyIF5IU9uIhvkyN7iiXmQUIOj8x/lB6f0bTaQ3ZA+9iaNCH2Lpg6btsBIRJOpJl0E9ABTvof5kqEGeCjMaN/AnRMgM5XJcI2J1J1gf6S48Tb2Ae6JkAjdgmAeJ1XAOJ1Xg8wGJ6elXwAzkeGjy62BgxG3MuXnoCIkmEq8EQyAUPgajyhPxJAga9SIiRqzwMOuAbGZDrDjQRgKkpiqiPgFphM74B7d4BKy2cyy1RcBvSodUb/HiSAIl+VlEfh8cm4wvPL9nnw+gbc+kkkUVioO95etwe8PBuP8vQoBzg7UQAe5t7syZwoCaMA3AN30wlzh3MYJYkkADeYTckYuJYlkiSVBeCKZtSY/gxlqezlxEt+pdFg6zBesPXn1ih8Aj5vkAels9PhYCkPsl++kg0AQu4dyuqmugIQm+qS5Nv6N+D7wm7d1skPc4xu666Fhd6BxU6r+jub8tNaWNxK29EhsdpR/sVn7FlLm0txPdgni+JrFNd3p+K67MQtyrsp3w2G7xbHd5Plv83z3Wj6b3V9N9ssFv7afaa//ZPn3wD4/vje8PP/N7TebS0hgZhEAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDE4LTA4LTIyVDE3OjUyOjIyKzAyOjAwc2qUYAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAxOC0wOC0yMlQxNzo1MjoyMiswMjowMAI3LNwAAAAZdEVYdFNvZnR3YXJlAHd3dy5pbmtzY2FwZS5vcmeb7jwaAAAAAElFTkSuQmCC"
    },
    "bordered": false
  },

Issues are:

1. Update takes more than 2 seconds now (looks as 4, because of https://github.com/Toxblh/MTMR/pull/297/files#diff-41994de6f4662cc2cec06819ff822c55R67 ?) and because of that it's two times slower to update the data. refreshInterval is 2.
2. I started to see "error" there instead of result from time to time (not happened before). If it can't be fixed, maybe we can skip update of the title (to not show "error").

If crash is around readDataToEndOfFile then maybe we can check if that method can be executed beforehand?