-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Addon API for /town buy #7177
Merged
LlmDl
merged 9 commits into
TownyAdvanced:master
from
lexiccn:feature/town-buy-command-addon-api
Jan 9, 2024
Merged
Command Addon API for /town buy #7177
LlmDl
merged 9 commits into
TownyAdvanced:master
from
lexiccn:feature/town-buy-command-addon-api
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
requested changes
Jan 8, 2024
Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java
Outdated
Show resolved
Hide resolved
Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java
Show resolved
Hide resolved
LlmDl
approved these changes
Jan 9, 2024
LlmDl
reviewed
Jan 9, 2024
Similar to how we handled the list permission changing.
LlmDl
added a commit
that referenced
this pull request
Jan 9, 2024
PR #7177. (First-Time Contributor!) - It is now possible for other plugins to add subcommands to the /town buy command. - Closes #6379. - New Permission Node: towny.command.town.buy.* - Child Nodes: - towny.command.town.buy.bonus - Allows mayors to use /t buy bonus. - No change required in your townyperms.yml, the old node towny.command.town.buy will continue to point to towny.command.town.buy.bonus, although it is recommended you change over to using the new towny.command.town.buy.* instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds Command Addon API use for /town buy, allowing developers to integrate commands here, for example
/town buy tiers
Additionally modifies the behaviour of /town buy (bonus):
/town buy
with no argument, or a non-existent argument now applies to/town buy bonus
without an argument, with a slightly reduced display (removes the title and command help)/town buy bonus
with no argument is removed, previously this would give an error to provide an amount/integer/town buy
help menu with a translatable help message, keytown_buy_help
in en-US.ymlNew Nodes/Commands/ConfigOptions:
towny.command.town.buy.*
- Wildcard permission for /town buy commandtowny.command.town.buy.bonus
- Effectively replaces towny.command.town.buy permission, child node oftowny.command.town.buy.*
Relevant Towny Issue ticket:
#6379
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.