Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plot groups extend townyobject #7141

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Make plot groups extend townyobject #7141

merged 2 commits into from
Jan 3, 2024

Conversation

Warriorrrr
Copy link
Member

Description:


Relevant Towny Issue ticket:

Closes #6092


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Warriorrrr Warriorrrr added this to the 0.100.1.0 milestone Dec 27, 2023
Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both flatfile and sql classes need to have the metadata get saved, and the plotgroup will need to have metadata added to its columns in the sqlschema.

@LlmDl LlmDl merged commit 2368e4f into master Jan 3, 2024
4 checks passed
@LlmDl LlmDl deleted the feat/group-townyobject branch January 3, 2024 15:57
LlmDl added a commit that referenced this pull request Jan 3, 2024
with PR #7158.
  - Make plot groups extend townyobject, courtesy of Warrior with
PR #7141.
    - Closes #6092.
  - Bump org.apache.logging.log4j:log4j-core from 2.22.0 to 2.22.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Ability to add metadata to plot groups
2 participants