TrustTown command #6276
TrustTown command #6276
Conversation
|
Sorry about the review (relatively new to Github, not quite sure if that review even contains latest commits) but have made a new commit which addresses all requested/suggested changes. |
There was a problem hiding this comment.
Something which has to be discussed is how dangerous this command would be:
- Mayor A is basically giving another mayor and a group of assistants the ability to allow anyone to be trusted in Mayor A's town.
- This could be a disaster if a trusted town is Open or becomes Open after becoming trusted.
- For this reason, the adding of trusted towns needs to be locked behind a Confirmation that makes the mayor aware of the danger they're putting their town in when they add another town as trusted.
The rest of the PR is coming together nicely, I'll be able to review it again after the Confirmation is added and the other small requests are addressed.
|
Just to give you a little hint, you don't need to manually commit these suggestions, you can simply accept these over GitHub |
|
The suggestions requesting swapping args[0] and the subcommands "add" aren't necessary. If we cared about that we'd be refactoring most of the command classes. You can accept the stream/foreach stuff if you want. |
I kind of understand that, but we can now start to change this MR by MR. Swapping this increases the readability and also makes more sense because we check whether the specific string is equal of some param and not the other way around |
I don't really care for it and I don't see a point in changing this now. |
|
I got a bit ahead of myself and implemented all requests before scrolling to the bottom lol, I can create a new commit again undoing the changes regarding swapping args[0] and the subcommands if wanted. |
Yep this would be a goo idea. You can than simply apply my suggestions here on the website, rather than committing than manually. |
|
I'm not entirely certain who Nico is, whether they're on the discord or not. They aren't a Towny org member though. |
|
Appreciate the advice Nico regarding adding commits directly on site, saw that button but wasn't sure if they would format correctly, I take it being Github though they have probably factored that into the design and works as intended. Otherwise have made a new commit addressing current issues laid out regarding reverting some formatting changes, events and the issue with removeAllTrustedTowns() |
Nope, im currently not in discord, just found this nice project and wanted to contribute |
Formatting should work fine, never experienced any bugs with it |
src/com/palmergames/bukkit/towny/event/town/TownTrustTownRemoveEvent.java
Show resolved
Hide resolved
This commit adds a new feature where you can trust a town in it's entirety. This is envisioned to supplement war modes that feature true conquest greatly.
Remove commented code and remove stray line.
Changes requested/suggested by LimDL and nicosammito.
This commit adds a confirmation box, accompanying text and renames an incorrectly named method.
- It is now possible for a town to add another town as trusted.
- This means that anyone in the 2nd town can do any
build/destroy/switch/itemuse as if they were a mayor in the first town.
- Obviously this should only be given out under very limited
circumstances, anyone added to the 2nd town after trust is given will
also have full plot perm rights in the first town.
- There is a confirmation warning the player that uses the /t
trusttown add command.
- New Command: /ta [townname] trusttown
- Requires towny.command.townyadmin.town.trusttown permission node.
- Subcommands:
- add *townname*
- remove *townname*
- list
- New Command: /t trusttown
- Requires towny.command.town.trusttown permission node.
- Subcommands:
- add [townname]
- remove [townname]
- list
Description:
This pull request adds a new command to town commands titled
trusttown, this allows a town member with appropriate permissions the ability to trust an entire town at once. This is envisioned to greatly supplement servers which use war modes which have true conquering of towns, as nation level permissions can often become messy.New Nodes/Commands/ConfigOptions:
New permission nodes:
towny.command.town.trusttowntowny.command.townyadmin.town.trusttownNew commands:
/t trusttown add *townname*/t trusttown remove *townname*/t trusttown list/ta *townname* trusttown add *townname*/ta *townname* trusttown remove *townname*/ta *townname* trusttown listRelevant Towny Issue ticket:
N/A
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.