Added is_trusted placeholders #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlmDl
requested changes
Oct 16, 2022
There was a problem hiding this comment.
This actually has to be done lower in the getPlayerPlaceholder(Player player, String identifier) and use the Town from the townBlock like so:
return townblock != null ? String.valueOf(townblock.getTownOrNull().hasTrustedResident(resident)) : "";
because a resident doesn't have to be a member of the town to become trusted there.
LlmDl
requested changes
Oct 16, 2022
|
Alright |
|
Should the default value be "" or "false"? |
|
The "" is only going to appear in the wilderness, it might make sense to just leave it blank. |
|
Please don't forget to add the hacktoberfest label :D |
LlmDl
approved these changes
Oct 16, 2022
LlmDl
added a commit
that referenced
this pull request
Oct 16, 2022
closing #6230. - %townyadvanced_player_town_is_trusted% - returns True or False based on whether the player is in a town, and is trusted in the town. - %townyadvanced_player_plot_is_trusted% - returns True or False based on whether the player is in a town, and is trusted in the plot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
Closes #6230
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.