Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /ta checkperm having incorrect tab completions #5830

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

altruiis
Copy link

Description:

This PR fixes a small issue with the /ta checkperm command having the tab completion of /ta database. I tested it for functionality and it works fine, but I am unsure as to how efficient it is (Especially on servers with lots of permissions. I have 16 plugins on my test server and did not notice any lag). I am also still very new to Git/PRs so if I messed anything up let me know.


New Nodes/Commands/ConfigOptions:

N/A


Relevant Towny Issue ticket:

N/A


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

Old behavior
image

New behavior
image
image
image

Copy link
Member

@LlmDl LlmDl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, I don't know why checkperms was added to the tabcompleter but never finished. I'll be merging this into the next pre-release. Also, nice first time contribution!

@altruiis
Copy link
Author

This is really great, I don't know why checkperms was added to the tabcompleter but never finished. I'll be merging this into the next pre-release. Also, nice first time contribution!

Thank you! I had a question though: I forgot #5494 was a thing, so should I swap the BukkitTools methods over to the regular Bukkit ones, or is it fine as-is?

@LlmDl LlmDl added this to the 0.98.2.0 milestone Mar 28, 2022
@LlmDl LlmDl merged commit df927b6 into TownyAdvanced:master Mar 28, 2022
@LlmDl
Copy link
Member

LlmDl commented Mar 28, 2022

It's fine as it is, thanks again.

@altruiis altruiis deleted the fix/checkperm-tab-completion branch March 29, 2022 00:43
LlmDl added a commit that referenced this pull request Mar 29, 2022
#5832.
  - Fix /ta checkperm having incorrect tab completions, courtesy of
Altruiis with PR #5830. (First-Time Contributor!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants