Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Config option to prevent claiming water chunks #7136

Closed
HerbertsStudios opened this issue Dec 24, 2023 · 5 comments · Fixed by #7145
Closed

Suggestion: Config option to prevent claiming water chunks #7136

HerbertsStudios opened this issue Dec 24, 2023 · 5 comments · Fixed by #7145
Assignees
@LlmDl
Labels
Completed enhancement
Milestone
0.100.1.0

Comments

@HerbertsStudios
Copy link

Please explain your feature request to the best of your abilities:

Please add an ability to prevent claiming water chunks, what i mean is if the entirety of the surface is water like an ocean chunk then it wont be allowed to be claimed

I have this issue where people keep claiming chunks of water near towns that have a large coast line so they can just tp to it and prevent having to actually go to the town
@LlmDl
Copy link
Member

LlmDl commented Dec 24, 2023

This is a feature in TownyProvinces already. but that plugin has a lot more going on that just blocking water claiming. I might look into what it would take to make this a standalone plugin/feature after Christmas.

@HerbertsStudios
Copy link
Author

Alright thank you, it would be cool if it was a base feature as many users do not use towny provinces. Happy holidays!

@LlmDl
Copy link
Member

LlmDl commented Dec 24, 2023

Yeah TownyProvinces is something you have to implement from teh start or not at all.

Of note:
This will have to be based off of the chunk's biome. Using just surface water will result in players just building some dirt on the water to bypass the plugin. I will likely do some sort of threshold of ocean-variety biome: if its greater than 50% ocean you cannot claim it.

@HerbertsStudios
Copy link
Author

Sounds good, could the threshold be a configurable percentage?

@LlmDl
Copy link
Member

LlmDl commented Dec 24, 2023

Yep

@Warriorrrr Warriorrrr changed the title Suggestion: Suggestion: Config option to prevent claiming water chunks Dec 27, 2023
LlmDl added a commit that referenced this issue Dec 27, 2023
@LlmDl
Add the ability to block claiming in plots which have too much Ocean
c316020 
biome in them.

The amount of allowed ocean is configurable.

Closes #7136.
@LlmDl LlmDl mentioned this issue Dec 27, 2023
Merged
1 task
@LlmDl LlmDl self-assigned this Dec 27, 2023
@LlmDl LlmDl added this to the 0.100.1.0 milestone Dec 27, 2023
LlmDl added a commit that referenced this issue Dec 29, 2023
@LlmDl
Add the ability to block claiming in plots which have too much Ocean …
499208d 
…or otherwise Unwanted biome in them. (#7145)

* Add the ability to block claiming in plots which have too much Ocean
biome in them.

The amount of allowed ocean is configurable.

Closes #7136.

* Add unwanted biomes option to make this more feature complete.

* Fix all teh things.

* Fix an errant s.
LlmDl added a commit that referenced this issue Dec 29, 2023
@LlmDl
- Add the ability to block claiming in plots which have too much Ocean
e9ff708 
or otherwise Unwanted biome in them.
    - Closes #7136.
  - New Config Option: claiming.biome_rules.unwanted_biomes.enabled
    - Default: false
    - When true, unwanted biomes will be tested for when a player is
claiming land.
  - New Config Option: claiming.biome_rules.unwanted_biomes.biomes
    - Default:
"the_end,end_barrens,end_highlands,end_midlands,small_end_islands"
    - A comma separated list of biome names that will add up towards a
townblock's un-claim-ability.
  - New Config Option: claiming.biome_rules.unwanted_biomes.threshold
    - Default: 55
    - The max amount of combined unwanted biomes as a percent, that will
be allowed in plots being claimed by towns.
    - For example, if a townblock would be more than X percent ocean it
will not be able to be claimed.
  - New Config Option: claiming.biome_rules.ocean_blocking.enabled
    - Default: false
    - When true, any wilderness plot which has more Ocean biome in it
than the allowed threshold (see below,) will not be able to be claimed.
  - New Config Option: claiming.biome_rules.ocean_blocking.threshold
    - Default: 55
    - The max amount of combined ocean biomes as a percent, that will be
allowed in plots being claimed by towns.
    - For example, if a townblock would be more than X percent ocean it
will not be able to be claimed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LlmDl LlmDl

Labels
Completed enhancement
Projects
None yet
Milestone
0.100.1.0
2 participants
@LlmDl @HerbertsStudios