Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falling Blocks bypass Build perms #6312

Closed
lexiccn opened this issue Nov 16, 2022 · 5 comments · Fixed by #6314
Closed

Falling Blocks bypass Build perms #6312

lexiccn opened this issue Nov 16, 2022 · 5 comments · Fixed by #6314

Comments

@lexiccn
Copy link
Contributor

lexiccn commented Nov 16, 2022

What steps will reproduce the problem?

  1. Build a kick-ass sand shooter outside someone's town
  2. Fire the kick-ass sand shooter into their town
  3. Sand lands in the town as a block

What is the expected output?

I guess that the sand breaks on landing like when it lands on slabs?

Towny version

Reproduced on multiple servers; but on my own: Towny-0.98.4.0

Server version

1.19.2 PaperMC

Please use Pastebin.com to link the following files

  1. Your full server startup from the logs\latest.log: Unable to post due to "potentially offensive" - should not matter
  2. Your Towny config.yml: https://pastebin.com/mVfm8izJ
  3. Your townyperms.yml: https://pastebin.com/X8iVDc16
  4. Your log's error: No error

(optional) If this is to do with permissions,
5. Your permissions file: No perms used besides TownyPerms

(optional) If this is to do with chat,
6. Your chatconfig.yml:
7. Your channels.yml:

@lexiccn lexiccn added the bug label Nov 16, 2022
@lexiccn
Copy link
Contributor Author

lexiccn commented Nov 16, 2022

I should add this isn't really an issue; I was working on patching for my own use but I didn't find any mention of it so I thought it was worth noting in-case it's not intended

@LlmDl
Copy link
Member

LlmDl commented Nov 16, 2022

Is there even an event for when sand goes airborn?

@lexiccn
Copy link
Contributor Author

lexiccn commented Nov 16, 2022

Not that I can find - my way of patching was (in my mind so maybe doesn't work out this way) to try and block it when the sand block is created; if the origin was a falling block

In saying that; it would break falling sand from people who do have perms so it's 50/50

I can't find anything on Spigot for becoming a falling block however

@lexiccn
Copy link
Contributor Author

lexiccn commented Nov 16, 2022

Apparently EntityChangeBlockEvent can record both it changing into & from a falling block

In theory then the location can be checked on both?

@LlmDl
Copy link
Member

LlmDl commented Nov 16, 2022

If that's teh case then something can be done.

@Warriorrrr Warriorrrr added this to the 0.98.5.0 milestone Nov 16, 2022
LlmDl added a commit that referenced this issue Nov 16, 2022
Warriorrrr with PR #6307.
    - Displays a player's nation name or, if no nation, their town name
or, blank if they have no town.
    - Closes #6294.
  - Prevent falling blocks from being launched into towns, courtesy of
Warriorrrr with PR #6314.
    - Requires your server to be using Paper, Spigot does not have this
in their API.
    - Closes #6312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants