Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Prevent attachable blocks from dropping and regenerating from explosions. #5689

Closed
LlmDl opened this issue Jan 30, 2022 · 0 comments · Fixed by #7176
Closed

Suggestion: Prevent attachable blocks from dropping and regenerating from explosions. #5689

LlmDl opened this issue Jan 30, 2022 · 0 comments · Fixed by #7176
Assignees
@LlmDl
Labels
enhancement
Milestone
0.100.1.0

Comments

@LlmDl
Copy link
Member

LlmDl commented Jan 30, 2022

Please explain your feature request to the best of your abilities:

Blocks like pressure plates, torches and rails, when blown up, will drop their item on the ground. The block will then regenerate (if it is actually considered blown up,) leading to a duplication of items.

Blocks which are not part of the actual explosion will just drop.

Ideally the blocks will not drop if they're part of the explosion. If they are only dropping because their surface block is exploded, they should regenerate (and not drop.)
@LlmDl LlmDl mentioned this issue Jan 30, 2022
Closed
@Warriorrrr Warriorrrr mentioned this issue Jan 3, 2024
Closed
LlmDl added a commit that referenced this issue Jan 8, 2024
@LlmDl
Working implementation preventing the drops that spawn from problem
1bce909 
blocks.

Many attachable blocks are not given the Attachable interface, making
that basically useless.

Instead an ItemLists was made up to keep the explodable attachables in
check during the ProtectionRegenTasks, which now takes special care to
nuke these blocks into Air.

Bonus: Adds ability to add ItemLists to ItemLists.

Closes #7154
Closes #5689
@LlmDl LlmDl self-assigned this Jan 8, 2024
@LlmDl LlmDl added this to the 0.100.1.0 milestone Jan 8, 2024
@LlmDl LlmDl mentioned this issue Jan 8, 2024
Merged
1 task
LlmDl added a commit that referenced this issue Jan 8, 2024
@LlmDl
Prevent the drops that spawn from problem blocks which can be duped i…
be2ce23 
…n explosion regenerations. (#7176)

* Working implementation preventing the drops that spawn from problem
blocks.

Many attachable blocks are not given the Attachable interface, making
that basically useless.

Instead an ItemLists was made up to keep the explodable attachables in
check during the ProtectionRegenTasks, which now takes special care to
nuke these blocks into Air.

Bonus: Adds ability to add ItemLists to ItemLists.

Closes #7154
Closes #5689

* Handle doors special case.
LlmDl added a commit that referenced this issue Jan 8, 2024
@LlmDl
- Prevent the drops that spawn from problem blocks which can be duped
1bc2d6a 
in explosion regenerations.
    - These were things like carpets, pressureplates and other blocks
that attach to blocks.
    - Closes #7154, #5689.
  - Add claiming particle effect.
  - New Config Option: claiming.show_claiming_particles
    - Default: true
    - When false players will not see the particle flood effect when
they claim townblocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LlmDl LlmDl

Labels
enhancement
Projects
None yet
Milestone
0.100.1.0
1 participant
@LlmDl