Merge pull request #6165 from TownyAdvanced/feature/thread-safe-geton…

…lineplayers Make TownyAPI#getOnlinePlayers(ResidentList) thread safe
TownyAdvanced · Sep 12, 2022 · ce4e7fb · ce4e7fb
2 parents 0c3bf86 + e6e55e4
commit ce4e7fb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/com/palmergames/bukkit/towny/TownyAPI.java b/src/com/palmergames/bukkit/towny/TownyAPI.java
@@ -374,8 +374,11 @@ public UUID getPlayerUUID(Resident resident) {
      * @return {@link List} of all online {@link Player}s in the specified {@link ResidentList}.
      */
     public List<Player> getOnlinePlayers(ResidentList owner) {
-        return Bukkit.getOnlinePlayers().stream().filter(player -> owner.hasResident(player.getName())).collect(Collectors.toList());
-    }
+		final List<Player> players = new ArrayList<>(Bukkit.getOnlinePlayers());
+
+		players.removeIf(player -> !owner.hasResident(player.getName()));
+		return players;
+	}
 
     /**
      * Gets all online {@link Player}s for a specific {@link Town}.