Use Towny's keepinv event to provide better compatiblity with other plugins. #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins. While maintaining SW having the final say for inventories in SiegeZones.
|
This PR cannot be merged until Towny's events are changed to fire in the wilderness and under any scenario. |
Goosius1
requested changes
Jun 8, 2023
|
Did Towny's Events change in the required way for this PR? |
|
Nope, this one should still be on standby.
…On Mon, Jul 17, 2023 at 5:32 AM Goosius1 ***@***.***> wrote:
Did Towny's Events change in the required way for this PR?
—
Reply to this email directly, view it on GitHub
<#845 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGWZDGOYWRCCFVAJNN7H5DXQUPGBANCNFSM6AAAAAAYY3BVSU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
LlmDl
added a commit
to TownyAdvanced/Towny
that referenced
this pull request
Nov 17, 2023
thrown in the wilderness, and to reduce the number of times Events will have to be cancelled. Unblocks TownyAdvanced/SiegeWar#845
1 task
LlmDl
added a commit
to TownyAdvanced/Towny
that referenced
this pull request
Nov 22, 2023
* Refactor KeepInventory/KeepExperience code to support Events being thrown in the wilderness, and to reduce the number of times Events will have to be cancelled. Unblocks TownyAdvanced/SiegeWar#845 * Slight tweak. * Return early when we can.
LlmDl
added a commit
to TownyAdvanced/Towny
that referenced
this pull request
Nov 22, 2023
- Closes #7099. - Refactor KeepInventory and KeepExperience code. - Unblocks TownyAdvanced/SiegeWar#845. - Immediately schedule upcoming newday on paper servers, courtesy of Warrior with PR #7101. - Bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.1 to 3.2.2. - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.0 to 3.6.2. - Bump org.jetbrains:annotations from 24.0.1 to 24.1.0. - Bump com.github.seeseemelk:MockBukkit-v1.20 from 3.44.0 to 3.47.0. - Bump org.apache.commons:commons-compress from 1.24.0 to 1.25.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While maintaining SW having the final say for inventories in SiegeZones.
New Nodes/Commands/ConfigOptions:
Relevant Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.