Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Save Settings more intuitive #132

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Dec 11, 2021

  • Don't close if user has cancelled "saving sattings as"
  • Don't update last_successfully_loaded_settings_file_path if load was not successful
  • "Save Settings As" defaults to the last_successfully_loaded_settings_file_path THEN the .exe
  • When closing app, use save_settings instead of save_settings_as

.

  • Removed more attributes from AutoSplit class

Don't close if user has cancelled "saving sattings as"
Removed more attributes from AutoSplit class
Don't update last_successfully_loaded_settings_file_path if load was not successful
"Save Settings As" defaults to the last_successfully_loaded_settings_file_path THEN the .exe
When closing app, ue save_settings instead of save_settings_as
@Toufool Toufool merged commit 1736443 into Toufool:2.0.0 Dec 14, 2021
@Avasam Avasam deleted the Make-Save-Settings-more-intuitive branch September 4, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants