Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from closed capture window Fixes #94 #129

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Dec 8, 2021

Features:

Fixed "Select Window" not working for windows with negative coordinates
Closes #94:

  • No pop-up on loading settings with no capture window
    • Pickup window capture on load if exists
  • Don't stop/reset AutoSplit upon loosing capture window
  • No pop-up on loosing capture window
    • Recover capture upon re-openning window
  • Don't allow selecting desktop.

Code cleanup and regressions fixed:

Fix crash on closing window mid-run
Split screen_region in smaller functions
Forgot to migrate split_delay to image.delay
Removed dead load_pyqt_settings code
Clearer local linting
Fixed dummy groups
Pause time from filename not set correctly
Setting hotkeys on load

Split screen_region in smaller functions
WIP towards Toufool#94:
No pop-up on loading settings with no capture window
 Don't stop/reset AutoSplit upon loosing capture window
 No pop-up on loosing capture window
 Don't allow selecting desktop.
Fixed regressions:
Fix crash on clising window mid-run
Forgot to migrate split_delay to image.delay
Removed dead load_pyqt_settings code
Fixed dummy groups
Pause time from filename not set correctly
Setting hotkeys on load
@Avasam Avasam force-pushed the Recover-from-closed-capture-window branch from 25b7ad2 to 84a5bb4 Compare December 8, 2021 18:13
@Toufool Toufool merged commit 709e6c1 into Toufool:2.0.0 Dec 10, 2021
@Avasam Avasam deleted the Recover-from-closed-capture-window branch December 10, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants