Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #86 Stop uncaught exceptions from silently crashing the app #118

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Fixes #86 Stop uncaught exceptions from silently crashing the app #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25dece7
Fixes #86 Stop uncaught exceptions from silently crashing the app
Avasam Nov 28, 2021
cc6066c
Merge branch 'dev' of https://github.com/Toufool/Auto-Split into show…
Avasam Nov 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/AutoSplit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
DISPLAY_RESIZE_WIDTH = 240
DISPLAY_RESIZE_HEIGHT = 180
DISPLAY_RESIZE = (DISPLAY_RESIZE_WIDTH, DISPLAY_RESIZE_HEIGHT)

CREATE_NEW_ISSUE_MESSAGE = \
"Please create a New Issue at <a href='https://github.com/Toufool/Auto-Split/issues'>"
"github.com/Toufool/Auto-Split/issues</a>, describe what happened, and copy & paste the error message below"

class AutoSplit(QtWidgets.QMainWindow, design.Ui_MainWindow):
from hotkeys import send_command
Expand Down Expand Up @@ -1216,9 +1218,7 @@ def main():
# Print error to console if not running in executable
if getattr(sys, 'frozen', False):
error_messages.exceptionTraceback(
"AutoSplit encountered an unrecoverable exception and will now close itself.<br/>"
"Please copy the following message over at<br/>"
"<a href='https://github.com/Toufool/Auto-Split/issues'>github.com/Toufool/Auto-Split/issues</a>",
f"AutoSplit encountered an unrecoverable exception and will now close. {CREATE_NEW_ISSUE_MESSAGE}",
exception)
else:
traceback.print_exception(type(exception), exception, exception.__traceback__)
Expand All @@ -1236,9 +1236,7 @@ def excepthook(exceptionType: Type[BaseException], exception: BaseException, tra
sys.exit(0)
error_messages.exceptionTraceback(
"AutoSplit encountered an unhandled exception and will try to recover, "
"however, things may not work quite right.<br/>"
"Please copy the following message over at<br/>"
"<a href='https://github.com/Toufool/Auto-Split/issues'>github.com/Toufool/Auto-Split/issues</a>",
f"however, there is no guarantee everything will work properly. {CREATE_NEW_ISSUE_MESSAGE}",
exception)


Expand Down