Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] NKGlobalParameters map serializable in 2.11 #900

Merged
merged 1 commit into from
Apr 28, 2020
Merged

[FIX] NKGlobalParameters map serializable in 2.11 #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ne/flink/api/src/main/scala/pl/touk/nussknacker/engine/flink/api/NkGlobalParameters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,13 @@ case class NkGlobalParameters(buildInfo: String,
//For now it will be only deployment information
//NOTE: this information is used in FlinkRestManager - any changes here should be reflected there
override def toMap: util.Map[String, String] = {
Map[String, String](
//we wrap in HashMap because .asJava creates not-serializable map in 2.11
new util.HashMap(Map[String, String](
"buildInfo" -> buildInfo,
"versionId" -> processVersion.versionId.toString,
"modelVersion" -> processVersion.modelVersion.map(_.toString).orNull,
"user" -> processVersion.user
).filterNot(_._2 == null).asJava
).filterNot(_._2 == null).asJava)
}
}

Expand Down
2 changes: 0 additions & 2 deletions ...la/pl/touk/nussknacker/engine/management/streaming/FlinkStreamingProcessManagerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ class FlinkStreamingProcessManagerSpec extends FunSuite with Matchers with Strea

eventually {
val status = processManager.findJobStatus(ProcessName(processId)).futureValue
//TODO: logging to debug flaky test on travis, remove after correcting...
logger.info(s"Status for stop process: $status")
status.map(_.status) shouldBe Some(FlinkStateStatus.Finished)
}

Expand Down