[NU-1979] Flink MiniCluster: job recovery on start #7710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8548a91 to
a0d2bf5
Compare
|
updated: #7718 |
arkadius
commented
Mar 21, 2025
...gner/server/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentService.scala
Show resolved
Hide resolved
.../pl/touk/nussknacker/ui/process/deployment/reconciliation/ScenarioDeploymentReconciler.scala
Show resolved
Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/test/base/it/NuResourcesTest.scala
Show resolved
Hide resolved
...ner/server/src/test/scala/pl/touk/nussknacker/ui/notifications/NotificationServiceTest.scala
Show resolved
Hide resolved
| @@ -72,84 +72,6 @@ class StreamingEmbeddedDeploymentManagerTest | |||
| manager.getScenarioDeploymentsStatuses(name).futureValue.value shouldBe List.empty | |||
| } | |||
|
|
|||
| test("Run persisted scenario deployments") { | |||
There was a problem hiding this comment.
It is not so easy to test embedded DM after removing ProcessingTypeDeployedScenariosProvider. To do this, we should probably add some separated test for this DM inside designer module. I think that it is not a priority now, so I only tested if it works manually.
There was a problem hiding this comment.
Maybe should we leave todo somewhere?
arkadius
commented
Mar 21, 2025
.../pl/touk/nussknacker/ui/process/deployment/reconciliation/ScenarioDeploymentReconciler.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This change adapts the solution that worked for embedded DM to work with every DM (including the flink mini-cluster). Now, it is part of the reconciliation process done on the designer's side instead of the DM's side.
Checklist before merge