Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-2071] Add test capabilities for event generator source #7626

Merged
merged 20 commits into from
Mar 13, 2025
Merged

[NU-2071] Add test capabilities for event generator source #7626

merged 20 commits into from
Mar 13, 2025

Conversation

mgoworko
Copy link
Contributor

Describe your changes

Added test capabilities (tests from file and ad-hoc) for event generator source:

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Mar 10, 2025
@mgoworko mgoworko marked this pull request as ready for review March 10, 2025 16:32
arkadius
arkadius reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test?

mgoworko
mgoworko commented Mar 11, 2025
View reviewed changes
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

created: #7656
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions @mgoworko
Updated snapshots (#7636)
be2d88a 
Co-authored-by: mgoworko <37329559+mgoworko@users.noreply.github.com>
@github-actions github-actions bot added client client main fe ui labels Mar 11, 2025
@mgoworko mgoworko requested a review from arkadius March 12, 2025 08:57
@github-actions github-actions bot removed client client main fe ui labels Mar 12, 2025
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Closed
@mgoworko mgoworko removed the request for review from arkadius March 13, 2025 15:37
@mgoworko mgoworko requested a review from arkadius March 13, 2025 15:37
@github-actions github-actions bot mentioned this pull request Mar 13, 2025
Closed
@mgoworko mgoworko merged commit 145526b into staging Mar 13, 2025
19 checks passed
@mgoworko mgoworko deleted the NU-2071-implement-test-capabilities-for-event-generator-source branch March 13, 2025 18:43
piotrp pushed a commit that referenced this pull request Mar 14, 2025
@mgoworko @piotrp
[NU-2071] Add test capabilities for event generator source (#7626)
726a56c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoworko @arkadius