Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-2015] Fix for component labels with prefix #7621

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

ForrestFairy
Copy link
Contributor

@ForrestFairy ForrestFairy commented Mar 7, 2025

Describe your changes

ComponentProvider can add prefix to component names. This is added after the creation of ComponentDefinition so label was created before this addition.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Sorry, something went wrong.

@ForrestFairy ForrestFairy force-pushed the fix-for-component-labels-with-prefix branch from b93febd to 370b6d6 Compare March 7, 2025 15:13
@ForrestFairy ForrestFairy requested a review from arkadius March 7, 2025 15:20
@ForrestFairy ForrestFairy force-pushed the fix-for-component-labels-with-prefix branch from 518f1b0 to 04e1832 Compare March 10, 2025 10:24
@ForrestFairy ForrestFairy requested a review from arkadius March 10, 2025 13:57
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ForrestFairy ForrestFairy merged commit 0f5c68d into staging Mar 11, 2025
18 of 19 checks passed
@ForrestFairy ForrestFairy deleted the fix-for-component-labels-with-prefix branch March 11, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants