Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1772] Refactor ScenarioActivity state handling #7007

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Oct 10, 2024

Describe your changes

Improvements concerning ScenarioActivity handling:

  1. After discussions on Thursday we decided, that failed or in-progress activities should not be displayed (so should not be returned by endpoint). That required refactor and explicit handling of activity state. No changes in DB, only in domain.
  2. Small fix - FE sends empty string as "no comment" on scenario update, fixed on BE.
  3. Small fix - when scenario is modified without changing the process graph, then the activity should not contain information about scenario version. It is then correctly displayed as "Scenario updated" instead of "Version X saved".

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@mgoworko mgoworko marked this pull request as ready for review October 10, 2024 16:34
Copy link
Contributor

github-actions bot commented Oct 14, 2024

none: #7013
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions github-actions bot added the docs label Oct 14, 2024
@mgoworko mgoworko requested a review from coutoPL October 15, 2024 11:55
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgoworko mgoworko merged commit ce844d3 into staging Oct 15, 2024
18 checks passed
@mgoworko mgoworko deleted the NU-1772-refactor-scenario-activity-state-handling branch October 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants