Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with more environments #5

Closed
wants to merge 2 commits into from
Closed

Testing with more environments #5

wants to merge 2 commits into from

Conversation

Saibamen
Copy link

No description provided.

@mproch
Copy link
Collaborator

mproch commented Apr 25, 2018

Thanks for PR. However, at the moment I think most of environments just won't work - I'm pretty sure we need at least scala 2.11, and flink currently does not support scala 2.12. What's more we have scala version specified in sbt - we are not cross-building nussknacker. Do you have any particular reason you'd like to see build with different scala versions?

@Saibamen
Copy link
Author

Saibamen commented Apr 26, 2018

@mproch
To be more stable and support more environments? For now only 2 envs runs correctly:

  • Scala: 2.11.8, JDK: oraclejdk8 (was previously tested)
  • Scala: 2.11.8, JDK: openjdk8 (was added by me)

I'm pretty sure we need at least scala 2.11

So please make it really sure, update your readme.md and remove scala < 2.11.X from my PR

@mproch
Copy link
Collaborator

mproch commented Apr 30, 2018

https://github.com/TouK/nussknacker/blob/master/README.md - I updated readme, after longest weekend in year we'll correct your PR, thanks

@Saibamen
Copy link
Author

Status?

@Saibamen Saibamen closed this Jun 17, 2018
@Saibamen Saibamen reopened this Jun 17, 2018
@Saibamen Saibamen closed this Jul 20, 2018
@Saibamen Saibamen reopened this Jul 20, 2018
@arkadius arkadius changed the base branch from master to staging November 7, 2019 12:09
@arkadius
Copy link
Member

arkadius commented Nov 7, 2019

Closing because of inactivity in this PR.

@arkadius arkadius closed this Nov 7, 2019
Dzuming added a commit that referenced this pull request Apr 30, 2024
…es' into preview/esp-pre-release-preview

# Conflicts:
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #4.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #5.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #7.png
Dzuming added a commit that referenced this pull request May 6, 2024
…ated-to-color-changes

# Conflicts:
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #4.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #5.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #7.png
Dzuming added a commit that referenced this pull request May 6, 2024
…es' into preview/esp-pre-release-preview

# Conflicts:
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Fragment should allow adding input parameters and display used fragment graph in modal #5.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Process view should have node search toolbar #0.png
#	designer/client/cypress/e2e/__image_snapshots__/electron/Linux/Process view should have node search toolbar #2.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants